Skip to content

Traktor S4MK3: fix wheel mode not getting set correctly on deck switch - #16083

Closed
ywwg wants to merge 1 commit into
mixxxdj:2.6from
ywwg:2.6
Closed

Traktor S4MK3: fix wheel mode not getting set correctly on deck switch#16083
ywwg wants to merge 1 commit into
mixxxdj:2.6from
ywwg:2.6

Conversation

@ywwg

@ywwg ywwg commented Mar 2, 2026

Copy link
Copy Markdown
Member

wheelmode was getting cleared before being saved

Signed-off-by: Owen Williams <owilliams@mixxx.org>
}
this.settings = settings;
this.secondDeckModes = null;
this.secondDeckModes = {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is right?

@acolombier

Copy link
Copy Markdown
Member

I am not sure to understand the bug and thus the fix. Could you provide actual reproduction steps and expected behaviour?

For reference, wheelMode and moveMode are expected to be undefined by default

@ywwg

ywwg commented Mar 2, 2026

Copy link
Copy Markdown
Member Author
  1. set the preference to "alternative mode"
  2. twist move knob on deck c -- it adjusts the move size
  3. select deck d
  4. select deck c
  5. twist move knob on deck c -- it does a beatjump, because the movemode is wrong

you can also see the bug by inspection: we set the movemode to null, then we try to save the current move mode under currentModes -- that persists the null setting, not the original movemode setting as intended. also compare to 2.5, where saving currentMode happens before the nullifying.

@ywwg

ywwg commented Mar 2, 2026

Copy link
Copy Markdown
Member Author

that first block I noted can probably be removed, except that in the deck switch logic there is no "else" case for when seconddeck.modes is null -- what is meant to happen in that condition?

@ywwg
ywwg requested a review from acolombier March 7, 2026 21:36
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

This PR is marked as stale because it has been open 90 days with no activity.

@ywwg

ywwg commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

alternative mode is not in main, so this is actually blocked on #15664

@ywwg ywwg closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controller mappings stale Stale issues that haven't been updated for a long time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants